Reject bad ipv6 hostnames #2076
Merged
+29
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erikdubbelboer
force-pushed
the
master
branch
from
18bceed to
0ad54a4
Compare
There was a problem hiding this comment.
Pull Request Overview
This PR adds validation to reject malformed IPv6 hostnames that contain mixed bracket syntax. It prevents the parser from accepting hostnames that incorrectly combine regular hostnames or IPv4 addresses with IPv6 bracket notation.
- Added validation to detect and reject hostnames with misplaced '[' or ']' characters outside proper IPv6 format
- Restructured the host parsing logic to check for invalid bracket usage before port validation
- Added comprehensive tests to verify rejection of mixed bracket hostname patterns
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| uri.go | Enhanced parseHost function to validate and reject hostnames with improper bracket usage |
| uri_test.go | Added test cases to verify rejection of malformed IPv6 hostnames with mixed bracket syntax |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
erikdubbelboer
force-pushed
the
fix-bad-ipv6
branch
from
03074c8 to
3dd6592
Compare
erikdubbelboer
force-pushed
the
fix-bad-ipv6
branch
from
3dd6592 to
74b1015
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.